libenchao commented on a change in pull request #11910:
URL: https://github.com/apache/flink/pull/11910#discussion_r415068116
##########
File path:
flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/scala/StreamSQLExample.scala
##########
@@ -49,12 +49,16 @@ object StreamSQLExample {
val env = StreamExecutionEnvironment.getExecutionEnvironment
val tEnv = if (planner == "blink") { // use blink planner in streaming
mode
val settings = EnvironmentSettings.newInstance()
- .useBlinkPlanner()
- .inStreamingMode()
- .build()
+ .useBlinkPlanner()
Review comment:
change the default planner to blink for line 46?
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/EnvironmentSettings.java
##########
@@ -159,8 +159,8 @@ public boolean isStreamingMode() {
private static final String BLINK_PLANNER_FACTORY =
"org.apache.flink.table.planner.delegation.BlinkPlannerFactory";
private static final String BLINK_EXECUTOR_FACTORY =
"org.apache.flink.table.planner.delegation.BlinkExecutorFactory";
- private String plannerClass = OLD_PLANNER_FACTORY;
Review comment:
also update java doc for `EnvironmentSettings`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
