becketqin commented on pull request #11856: URL: https://github.com/apache/flink/pull/11856#issuecomment-619653062
@StephanEwen Thanks for the review. You are right, the wakeup is difficult to make right. I found the major difficulty comes from the efforts to have "fine-grained" wakeup, i.e. avoid waking up the `SplitFetcher` unnecessarily, because we don't know if the call to `SplitFetcher.wakeup()` is always efficient. Maybe we don't really need to worry about this. If so, the code would be much more straightforward with a "coarse-grained" wakeup. I am curious about your suggestion of using `LockSupport`. Would be glad to hear the idea. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
