rmetzger commented on a change in pull request #11831:
URL: https://github.com/apache/flink/pull/11831#discussion_r415546344
##########
File path: flink-end-to-end-tests/test-scripts/test_ha_datastream.sh
##########
@@ -100,4 +102,21 @@ STATE_BACKEND_FILE_ASYNC=${2:-true}
STATE_BACKEND_ROCKS_INCREMENTAL=${3:-false}
ZOOKEEPER_VERSION=${4:-3.4}
-run_ha_test 4 ${STATE_BACKEND_TYPE} ${STATE_BACKEND_FILE_ASYNC}
${STATE_BACKEND_ROCKS_INCREMENTAL} ${ZOOKEEPER_VERSION}
+function kill_test_watchdog() {
+ local watchdog_pid=`cat $TEST_DATA_DIR/job_watchdog.pid`
+ echo "Stopping job timeout watchdog (with pid=$watchdog_pid)"
+ kill $watchdog_pid
+}
+on_exit kill_test_watchdog
+
+(
+ cmdpid=$BASHPID;
Review comment:
Yes, these changes require bash 4. Bash on mac is pretty outdated sadly.
I think `$$` won't work, as it will return the PID of the bash-process, not
of the subshell I'm launching there:
> When you want to find out the PID of your current shell session, even from
subshells, that’s when you use $$. Any subshell has its own PID as well, and
you can access it via the $BASHPID variable.
https://bashwizard.com/shells-subshells-pids/
But I will add a warning to the script, that is requires at least bash 4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
