twalthr commented on a change in pull request #11397:
URL: https://github.com/apache/flink/pull/11397#discussion_r415582576
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientTest.java
##########
@@ -190,6 +176,47 @@ public void write(int b) throws IOException {
}
}
+ @Test
+ public void testSetSessionPropertyWithException() throws Exception {
+ Executor executor = mock(Executor.class);
+ doThrow(new SqlExecutionException("Property 'parallelism' must
be a integer value but was: 10a"))
Review comment:
We should avoid using Mockito according to the Flink coding guidelines:
https://flink.apache.org/contributing/code-style-and-quality-common.html
```
Mockito-based tests tend to be costly to maintain in the long run by
encouraging duplication of functionality and testing for implementation rather
than effect
More details:
https://docs.google.com/presentation/d/1fZlTjOJscwmzYadPGl23aui6zopl94Mn5smG-rB0qT8
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
