[ 
https://issues.apache.org/jira/browse/FLINK-17403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093297#comment-17093297
 ] 

Xintong Song commented on FLINK-17403:
--------------------------------------

[~aljoscha]
 Thanks for pulling me in.

[~Paul Lin]
 Thanks for reporting this issue. It seems to me this is a valid problem. 

As for the solution, I think we probably also consider the possibility that 
there are jar files with other suffix under {{$FLINK_TARGET_DIR}}. E.g., 
{{flink-dist*-test.jar}}. Of course we could further filter the patterns for 
the {{find}} command. However, I'm in favor of an alternative approach to 
properly add all jar files that meets the pattern to the class path. That safes 
us from closely depending on the certain pattern of the name of flink dist jar 
file. WDYT?

> Fix invalid classpath in BashJavaUtilsITCase
> --------------------------------------------
>
>                 Key: FLINK-17403
>                 URL: https://issues.apache.org/jira/browse/FLINK-17403
>             Project: Flink
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 1.10.0
>            Reporter: Paul Lin
>            Priority: Major
>
> runBashJavaUtilsCmd.sh locates flink-dist.jar by `find` with pattern 
> `flink-dist*.jar`, but it doesn't filter out the flink-dist*-source.jar built 
> by maven and the flink-dist jar in the original bin directory, so it might 
> get 3 jars as the result, which might break the command depends on it.
> For instance, the result of `find` can be:
> ```
> project_dir/flink-dist/src/test/bin/../../../target/flink-dist_2.11-1.10.0-sources.jar
> project_dir/flink-dist/src/test/bin/../../../target/flink-1.10.0-bin/flink-1.10.0/lib/flink-dist_2.11-1.10.0.jar
> project_dirflink-dist/src/test/bin/../../../target/flink-dist_2.11-1.10.0.jar
> ```
> Moreover, there's a redundant `}` in the command, which seems to be 
> accidentally skipped by the multiple-line result provided by `find`.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to