zentol commented on a change in pull request #11912:
URL: https://github.com/apache/flink/pull/11912#discussion_r415748519
##########
File path: docs/monitoring/metrics.zh.md
##########
@@ -663,6 +663,7 @@ Example configuration:
{% highlight yaml %}
+metrics.reporter.influxdb.factory.class:
org.apache.flink.metrics.influxdb.InfluxdbReporterFactory
metrics.reporter.influxdb.class:
org.apache.flink.metrics.influxdb.InfluxdbReporter
Review comment:
We should only advertise the plugin approach.
```suggestion
```
##########
File path: docs/monitoring/metrics.md
##########
@@ -663,6 +663,7 @@ Example configuration:
{% highlight yaml %}
+metrics.reporter.influxdb.factory.class:
org.apache.flink.metrics.influxdb.InfluxdbReporterFactory
metrics.reporter.influxdb.class:
org.apache.flink.metrics.influxdb.InfluxdbReporter
Review comment:
We should only advertise the plugin approach.
```suggestion
```
##########
File path: flink-end-to-end-tests/test-scripts/common.sh
##########
@@ -591,6 +591,13 @@ function setup_flink_slf4j_metric_reporter() {
set_config_key "metrics.reporter.slf4j.interval" "${INTERVAL}"
}
+function setup_flink_influxdb_metric_reporter() {
Review comment:
without a test to make use of this there is little reason to add this
method,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
