wanglijie95 commented on a change in pull request #11499:
URL: https://github.com/apache/flink/pull/11499#discussion_r415331203
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCLookupFunction.java
##########
@@ -139,6 +139,14 @@ public void eval(Object... keys) {
for (int retry = 1; retry <= maxRetryTimes; retry++) {
try {
+ try {
Review comment:
Check whether connection is valid on each writes is expensive. How about
catching the "statement closed" exception (mentioned in FLINK-16681) and
solving it by creating a new connection in the catch code block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]