nielsbasjes edited a comment on pull request #11592:
URL: https://github.com/apache/flink/pull/11592#issuecomment-620473867


   So what it does now:
   1) There is no properties file --> everything returns a "default" value.
   These are the defaults I have chosen:
   
   ```
   Version : <unknown>
   ScalaVersion : <unknown>
   BuildTime : 1970-01-01T00:00:00Z
   BuildTimeString : 1970-01-01T00:00:00+0000
   GitCommitId : DecafC0ffeeD0d0F00d
   GitCommitIdAbbrev : DeadD0d0
   GitCommitTime : 1970-01-01T00:00:00Z
   GitCommitTimeString : 1970-01-01T00:00:00+0000
   ```
   2) A poorly generated properties file exists --> Only the bad values return 
a default.
   This happens because the maven git plugin is not run by the IDE.
   Example:
   ```
   project.version=1.11-SNAPSHOT
   scala.binary.version=2.11
   git.commit.id=${git.commit.id}
   git.commit.id.abbrev=${git.commit.id.abbrev}
   git.commit.time=${git.commit.time}
   git.build.time=${git.build.time}
   ```
   3) A full generated properties file exists --> Everything returns the right 
value.
   Example:
   ```
   project.version=1.11-SNAPSHOT
   scala.binary.version=2.11
   git.commit.id=8e2642ec0046bb02fe9c1648b589051e66c2f956
   git.commit.id.abbrev=8e2642e
   git.commit.time=2020-04-28T09:22:20+0200
   git.build.time=2020-04-28T10:06:42+0200
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to