rkhachatryan commented on a change in pull request #11899:
URL: https://github.com/apache/flink/pull/11899#discussion_r417394178
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -535,20 +540,16 @@ private void
startTriggeringCheckpoint(CheckpointTriggerRequest request) {
request.getOnCompletionFuture()),
timer);
- final CompletableFuture<?> masterStatesComplete =
pendingCheckpointCompletableFuture
- .thenCompose(this::snapshotMasterState);
+ final CompletableFuture<?> masterStatesComplete =
pendingCheckpointCompletableFuture.thenCompose(this::snapshotMasterState);
- final CompletableFuture<?>
coordinatorCheckpointsComplete = pendingCheckpointCompletableFuture
- .thenComposeAsync((pendingCheckpoint) ->
-
OperatorCoordinatorCheckpoints.triggerAndAcknowledgeAllCoordinatorCheckpointsWithCompletion(
-
coordinatorsToCheckpoint, pendingCheckpoint, timer),
- timer);
+ final CompletableFuture<?>
coordinatorCheckpointsComplete =
pendingCheckpointCompletableFuture.thenComposeAsync(
+ pendingCheckpoint ->
triggerAndAcknowledgeAllCoordinatorCheckpointsWithCompletion(coordinatorsToCheckpoint,
pendingCheckpoint, timer),
+ timer);
Review comment:
As Flink guidelines don't name any specific limit, I usually assume that
if it fits on my 14" screen then it could fit on most other devices:)
I think it makes sense to split the line to attract attention to something
important, but here it's just one lambda with one method call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
