[
https://issues.apache.org/jira/browse/FLINK-17469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17096447#comment-17096447
]
Aljoscha Krettek commented on FLINK-17469:
------------------------------------------
I'm definitely open to such a change and have some questions:
1. You mention that you need to evaluate this on a job-by-job basis. Is that
multiple jobs in the same {{main()}} method? If yes, would you set the system
property in between in code?
2. Another option, that I would actually prefer, is setting a default job name
in the {{flink-conf.yaml}} or potentially as a commandline option. Flink is
moving more and more in a direction where the commandline basically overrides
settings in the {{flink-conf.yaml}}, so everything should be configurable at
all levels. What are your thoughts on this vs. a system property?
Also, if we do this we should also update {{ExecutionEnvironment}} to match the
behaviour.
> Support override of DEFAULT_JOB_NAME with system property for
> StreamExecutionEnvironment
> ----------------------------------------------------------------------------------------
>
> Key: FLINK-17469
> URL: https://issues.apache.org/jira/browse/FLINK-17469
> Project: Flink
> Issue Type: New Feature
> Components: API / DataSet, API / DataStream
> Affects Versions: 1.10.0
> Reporter: John Lonergan
> Priority: Trivial
>
> We are running multiple jobs on a shared standalone HA Cluster.
> We want to be able to provide the job name via the submitting shell script
> using a system property; for example "job.name".
> We could of course write Java application code in each job to achieve this by
> passing the system property value ourselves to the execute(name) method,
> however we want to do this from the env.
> ---
> However, there exists already default job name in
> StreamExecutionEnvironment.DEFAULT_JOB_NAME.
> Our proposed changed to add a method to StreamExecutionEnvironment...
> {code:java}
> String getDefaultJobName() {
> return System.getProperty("default.job.name",
> StreamExecutionEnvironment.DEFAULT_JOB_NAME);
> }
> {code}
> .. and call that method rather than directly accessing
> StreamExecutionEnvironment.DEFAULT_JOB_NAME
> This change is backwards compatible.
> We need this method to evalulate on a job by job basis so for example the
> following small amendment to the existing DEFAULT_JOB_NAME value will NOT
> work because this will not allow us to vary the value job by job.
> {code:java}
> class StreamExecutionEnvironment {
> static final String DEFAULT_JOB_NAME =
> System.getProperty("default.job.name", "Flink Streaming Job"))
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
