rkhachatryan commented on a change in pull request #11948:
URL: https://github.com/apache/flink/pull/11948#discussion_r418027203
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -551,7 +551,7 @@ void onSenderBacklog(int backlog) throws IOException {
}
public void onBuffer(Buffer buffer, int sequenceNumber, int backlog)
throws IOException {
- boolean recycleBuffer = true;
+ boolean enqueued = false;
Review comment:
> In case of some parse exception, the whole TM is restarted anyways.
That's true for now, but it can change in the future.
> renaming and inversion is unnecessary
This is to give more context to prevent future bugs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
