zentol commented on a change in pull request #11965:
URL: https://github.com/apache/flink/pull/11965#discussion_r418217715



##########
File path: 
flink-connectors/flink-sql-connector-elasticsearch7/src/main/resources/META-INF/NOTICE
##########
@@ -6,10 +6,12 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software 
License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
+- com.carrotsearch:hppc:0.8.1

Review comment:
       Since the jar does not contain the NOTICE we do not have to forward it 
imo.
   
   > (d) **If** the Work includes a "NOTICE" text file as part of its
   >           **distribution**, then any Derivative Works that You distribute 
must
   >           include a readable copy of the attribution notices contained
   >           within such NOTICE file
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to