zhijiangW commented on a change in pull request #11687:
URL: https://github.com/apache/flink/pull/11687#discussion_r419508820
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -168,6 +175,12 @@ public void run() {
Optional<BufferAndAvailability> getNextBuffer() throws IOException,
InterruptedException {
checkError();
+ BufferAndAvailability bufferAndAvailability =
getNextRecoveredStateBuffer();
Review comment:
I am neutral for this option, because the similar way really existed in
many other places before. E.g. we have `BufferStorage` in
`CheckpointedInputGate` for caching the blocked channels' buffers, then while
`getNextBuffer` we also need to check whether there are any pending buffers to
be read from `BufferStorage` firstly.
I absolutely agree that it would be better to not have different paths, but
I also think it is not so bad if no other easy options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
