[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099947#comment-17099947
]
Dawid Wysakowicz commented on FLINK-16998:
------------------------------------------
Your discussion in the JIRA issue exactly reflects also my offline chat with
[~twalthr]. I agree it would be nice to remove the nested flag, but based on
the amount of work it would require I think it is fine to have it present. In
the end the `toString` method is more of an internal method for debugging
rather than a way we present it to users. When returning it as a result e.g.
via {{TableEnvironemnt#execute()}} we should consider a nicer formatting.
To sum up I am fine with having it as: {{-D(12, 12, +I(Hello, World))}}
> Add a changeflag to Row type
> ----------------------------
>
> Key: FLINK-16998
> URL: https://issues.apache.org/jira/browse/FLINK-16998
> Project: Flink
> Issue Type: Sub-task
> Components: API / Core
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
>
> In Blink planner, the change flag of records travelling through the pipeline
> are part of the record itself but not part of the logical schema. This
> simplifies the architecture and API in many cases.
> Which is why we aim adopt the same mechanism for
> {{org.apache.flink.types.Row}}.
> Take {{tableEnv.toRetractStream()}} as an example that returns either Scala
> or Java {{Tuple2<Boolean, Row>}}. For FLIP-95 we need to support more update
> kinds than just a binary boolean.
> This means:
> - Add a changeflag {{RowKind}} to to {{Row}}
> - Update the {{Row.toString()}} method
> - Update serializers in backwards compatible way
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
