Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1469#discussion_r49655529
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/NonReusingBuildFirstHashJoinIterator.java
---
@@ -144,13 +148,20 @@ public final boolean
callWithNextKey(FlatJoinFunction<V1, V2, O> matchFunction,
// only single pair matches
matchFunction.join(nextBuildSideRecord,
probeRecord, collector);
}
- }
- else if(joinWithEmptyBuildSide) {
- // build side is empty, join with null
- final V2 probeRecord =
this.hashJoin.getCurrentProbeRecord();
+ } else {
+ if (probeSideOuterJoin && probeRecord != null
&& nextBuildSideRecord == null) {
--- End diff --
Can you add a few comments in this `else` branch?
Please do the same for the other adapted HashJoinIterators.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
