Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1469#issuecomment-171452040
Hi @ChengXiangLi, very nice PR! Sorry for not reviewing it earlier.
I had only a few minor comments. I did not check the tests yet, but hope to
do it in the next days.
Although, I do not expect major performance implications for inner joins,
it would be good to check that to be on the safe side.
Have you done any performance regression tests?
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
