wsry opened a new pull request #12027:
URL: https://github.com/apache/flink/pull/12027
## What is the purpose of the change
For unaligned checkpoint, when checkpointing the inflight data of incoming
channel, both task thread and Netty thread may add data to the channel state
writer. More specifically, the task thread will first request inflight buffers
from the input channel and add the buffers to the channel state writer, and
then the Netty thread will add the following up buffers (if any) to the channel
state writer. The buffer adding of task thread and Netty thread is not
synchronized so the Netty thread may add buffers before the task thread which
leads to disorder of the data and corruption of the data stream.
This PR tries to fix the problem.
## Brief change log
- Make requesting and adding of inflight buffer of task thread happen in
synchronized block to avoid race condition.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
