[
https://issues.apache.org/jira/browse/FLINK-17530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103158#comment-17103158
]
Robert Metzger edited comment on FLINK-17530 at 5/9/20, 7:21 AM:
-----------------------------------------------------------------
In my opinion, we have the following options:
A) Allow reflective access to all packages in "java.base". This hides other
cases, but is generally not harmful.
Users won't see warnings from ClosureCleaner when submitting a job in Java 11.
B) Keep everything as-is. Users will see warnings.
C) Remove / Change ClosureCleaner: We could disable the ClosureCleaner by
default and add good logging / error messages for cases where the submitted job
is large.
I'm still leaning towards A), as reflective access is not really harmful.
was (Author: rmetzger):
In my opinion, we have the following options
A) Allow reflective access to all packages in "java.base". This hides other
cases, but is generally not harmful.
Users won't see warnings from ClosureCleaner when submitting a job in Java 11.
B) Keep everything as-is. Users will see warnings.
C) Remove / Change ClosureCleaner: We could disable the ClosureCleaner by
default and add good logging / error messages for cases where the submitted job
is large.
I'm still leaning towards A), as reflective access is not really harmful.
> Fix illegal reflective access by ClosureCleaner
> -----------------------------------------------
>
> Key: FLINK-17530
> URL: https://issues.apache.org/jira/browse/FLINK-17530
> Project: Flink
> Issue Type: Sub-task
> Components: API / DataStream
> Affects Versions: 1.11.0
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Priority: Major
> Fix For: 1.11.0
>
>
> To reproduce:
> {code}
> @Test
> public void testJava11Warning() {
> MapFunction<String, String> fun = new MapFunction<String,
> String>() {
> String field = "asdf";
> @Override
> public String map(String value) throws Exception {
> return value + field;
> }
> };
> ClosureCleaner.clean(fun,
> ExecutionConfig.ClosureCleanerLevel.RECURSIVE, false);
> }
> {code}
> Causes:
> {code}
> WARNING: Illegal reflective access by
> org.apache.flink.api.java.ClosureCleaner
> (file:/Users/robert/Projects/flink/flink-core/target/classes/) to field
> java.lang.String.value
> at
> org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:104)
> at
> org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:126)
> at
> org.apache.flink.api.java.ClosureCleaner.clean(ClosureCleaner.java:71)
> at
> org.apache.flink.api.java.ClosureCleanerTest.testJava11Warning(ClosureCleanerTest.java:58)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
