wuchong commented on a change in pull request #12047:
URL: https://github.com/apache/flink/pull/12047#discussion_r422484991



##########
File path: 
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java
##########
@@ -145,7 +157,9 @@ private static RowKind parseRowKind(String 
rowKindShortString) {
        // Factory
        // 
--------------------------------------------------------------------------------------------
 
-       public static final String IDENTIFIER = "values";
+       public static final AtomicInteger RESOURCE_COUNTER = new 
AtomicInteger();
+

Review comment:
       It is used for checking `open` and `close` are both invocked. The 
`RESOURCE_COUNTER` will be checked in 
https://github.com/apache/flink/pull/12047/files#diff-46716d3945346195315abf04aa338171R79




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to