KurtYoung commented on a change in pull request #12042:
URL: https://github.com/apache/flink/pull/12042#discussion_r422486671
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -894,14 +907,48 @@ private TableResult buildShowResult(String[] objects) {
.build();
}
- private String extractJobName(Operation operation) {
- String tableName;
- if (operation instanceof CatalogSinkModifyOperation) {
- tableName = ((CatalogSinkModifyOperation)
operation).getTableIdentifier().toString();
- } else {
- throw new UnsupportedOperationException("Unsupported
operation: " + operation);
+ /**
+ * extract sink identifier names from {@link ModifyOperation}s.
+ *
+ * <p>This method will keep the shortest form of an identifier,
+ * which should be unique between all identifiers. e.g.
+ * cat.db.tbl1, cat.db.tbl2, cat.db1.tbl3, cat.db2.tbl3, cat1.db.tbl4,
cat2.db.tbl4
+ * the result is
+ * tbl1, tbl2, db1.tbl3, db2.tbl3, cat1.db.tbl4, cat2.db.tbl4
+ */
+ private List<String> extractSinkIdentifierNames(List<ModifyOperation>
operations) {
Review comment:
I would prefer to keep it simple for now, just use the full identify is
enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
