[
https://issues.apache.org/jira/browse/FLINK-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098929#comment-15098929
]
ASF GitHub Bot commented on FLINK-2716:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1462#issuecomment-171789574
Looks good. One comment about parenthesis on the Scala methods, otherwise
good.
To safe testing uild time, we could add the tests of this to some existing
test class (like MiscellaneousITCase). Messes up class separation a bit, but
saves a lot of build time in the long run, because the main test time goes into
the starting to the test mini cluster (which is once per class).
> Checksum method for DataSet and Graph
> -------------------------------------
>
> Key: FLINK-2716
> URL: https://issues.apache.org/jira/browse/FLINK-2716
> Project: Flink
> Issue Type: Improvement
> Components: DataSet API, Gelly
> Affects Versions: 0.10.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Priority: Minor
>
> {{DataSet.count()}}, {{Graph.numberOfVertices()}}, and
> {{Graph.numberOfEdges()}} provide measures of the number of distributed data
> elements. New {{DataSet.checksum()}} and {{Graph.checksum()}} methods will
> summarize the content of data elements and support algorithm validation,
> integration testing, and benchmarking.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
