KurtYoung commented on a change in pull request #12049:
URL: https://github.com/apache/flink/pull/12049#discussion_r422809027
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/delegation/Planner.java
##########
@@ -74,14 +76,22 @@
*/
List<Transformation<?>> translate(List<ModifyOperation>
modifyOperations);
+ /**
+ * Creates a {@link SelectTableSink} for a select query.
+ *
+ * @param tableSchema the table schema of select result.
+ * @return The {@link SelectTableSink} for the select query.
+ */
+ SelectTableSink createSelectTableSink(TableSchema tableSchema);
Review comment:
This interface looks strange to me. An alternative approach is we create
another dedicated `ModifyOperation` which used for collecting, and reuse the
`List<Transformation<?>> translate(List<ModifyOperation> modifyOperations);`.
We can encapsulate the logic under this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
