zentol commented on a change in pull request #20:
URL: https://github.com/apache/flink-docker/pull/20#discussion_r422867843
##########
File path: docker-entrypoint.sh
##########
@@ -18,6 +18,8 @@
# limitations under the License.
###############################################################################
+COMMAND_STANDALONE="standalone-job"
Review comment:
@tillrohrmann I wouldn't use `application`; while the glossary contained
the concept of `Application Cluster` for years I don't think I have ever seen
it mentioned anywhere (especially not anywhere in flink-dist).
The current(master) glossary also says that a Flink _application_ can be
both submitted to a session or application cluster, so it isn't exactly clear
what `application` would do. Maybe this will change when FLIP-85 (Flink
Application Mode) is completed, _if_ it fully subsumes per-job clusters, but
until then I would stay away from this term.
Considering the potential future features outlined in the FLIP,
> Being able to launch one image in Kubernetes and the launched containers
will figure out who is the JM and who are the TMs.
the semantics of `application` could change again in the future, and it may
be best to reserve this term for that time.
@azagrebin I did not know that. I'd still stick with `standalone-job` though
to stay close to flink-dist. I very much want to prevent us from introducing
separate terminology into the docker images.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
