dawidwys commented on a change in pull request #12018:
URL: https://github.com/apache/flink/pull/12018#discussion_r422985918
##########
File path:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcherTest.java
##########
@@ -108,13 +112,13 @@ public void testSkipCorruptedRecord() throws Exception {
final KafkaTopicPartitionState<Object> partitionStateHolder =
fetcher.subscribedPartitionStates().get(0);
- fetcher.emitRecord(1L, partitionStateHolder, 1L);
- fetcher.emitRecord(2L, partitionStateHolder, 2L);
+ emitRecord(fetcher, 1L, partitionStateHolder, 1L);
Review comment:
There are two related changes:
* I changed a bit the way no results are emitted (null before/empty queue
now)
* I changed one test case slightly to emit multiple results in a single
`emitRecordsWithTimestamps`
I think after extracting the refactoring to a separate commit it is visible
more clearly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
