gaoyunhaii commented on a change in pull request #12053:
URL: https://github.com/apache/flink/pull/12053#discussion_r424813284
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
##########
@@ -65,6 +65,9 @@
private final RollingPolicy<IN, BucketID> rollingPolicy;
+ @Nullable
+ private final BucketLifeCycleListener<IN, BucketID>
bucketLifeCycleListener;
Review comment:
Do we need to supports more than one listeners currently ? I think we
might postpone the support if it could support the current use cases. We should
be able to keep compatibility with adding a new
`withBucketLifeCycleListener(List<BucketLifeCycleListener> listeners>` to the
format builder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
