SteNicholas commented on a change in pull request #12009: URL: https://github.com/apache/flink/pull/12009#discussion_r424857851
########## File path: flink-python/pyflink/common/job_client.py ########## @@ -0,0 +1,113 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ +from pyflink.common.completable_future import CompletableFuture +from pyflink.common.job_execution_result import JobExecutionResult +from pyflink.common.job_status import JobStatus + +__all__ = ['JobClient'] + + +class JobClient(object): + """ + A client that is scoped to a specific job. + """ + + def __init__(self, j_job_client): + self._j_job_client = j_job_client + + def get_job_id(self): + """ + Returns the JobID that uniquely identifies the job this client is scoped to. + + :return: JobID, or null if the job has been executed on a runtime without JobIDs + or if the execution failed. + """ + return str(self._j_job_client.getJobID()) Review comment: @hequn8128 I have add `JobID` class consistent with Java. Please review again for this. Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
