TsReaper commented on a change in pull request #12069:
URL: https://github.com/apache/flink/pull/12069#discussion_r424862739
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java
##########
@@ -162,9 +174,28 @@ public RetryingRegistrationConfiguration
getRetryingRegistrationConfiguration()
// Static factory methods
//
--------------------------------------------------------------------------------------------
+ @VisibleForTesting
public static TaskManagerConfiguration fromConfiguration(
Configuration configuration,
TaskExecutorResourceSpec taskExecutorResourceSpec) {
+ try {
+ TaskManagerServicesConfiguration servicesConfiguration =
+
TaskManagerServicesConfiguration.fromConfiguration(
+ configuration,
+ ResourceID.generate(),
+
InetAddress.getLoopbackAddress().getHostAddress(),
Review comment:
Task manager's address is read from the task manager config or from the
resource manager. If a host has multiple network interfaces, how can we make
sure that `InetAddress.getLoopbackAddress().getHostAddress()` returns the
address the task manager is working on?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
