pnowojski commented on pull request #12128: URL: https://github.com/apache/flink/pull/12128#issuecomment-628388920
Thanks for the review. I'm also missing a unit test here, however for exactly this reasons: > But the original bug is caused by passing invalid gates into the InputProcessUtil, so the above unit tests can not verify whether we passed the correct gates in specific topology graph. I decided that it's better to cover it via ITCase. After all `InputProcessUtil#createCheckpointedInputGate` is integrating a lot of things together, so it wouldn't be a unit test any way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org