cshuo opened a new pull request #12119:
URL: https://github.com/apache/flink/pull/12119


   …produce NPE in some cases existing aggregate call with Filter.
   
   ## What is the purpose of the change
   
   When generating code for Filter predicate of aggregate call in 
`HashAggCodeGenHelper`, we should check the nullability of the boolean field 
firstly rather than `getBoolean` directly, otherwise, NPE may be produced.
   
   ## Brief change log
   * This PR fix bugs in `HashAggCodeGenHelper`.
   
   ## Verifying this change
   This change added tests:
   * Add integration test in `AggregateITCaseBase` for end-to-end test.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to