zhijiangW commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r425079339
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -94,13 +99,22 @@ public void requestSubpartitionView(
}
@Override
- public void addCredit(int creditDeltas) {
+ public void addCredit(int creditDeltas) throws Exception {
numCreditsAvailable += creditDeltas;
+ requestQueue.enqueueAvailableReader(this, this::isAvailable);
+ }
+
+ @Override
+ public boolean shouldAnnounceBacklog() {
+ return !withoutExclusiveCredits && numCreditsAvailable == 0 &&
subpartitionView.isAvailable(Integer.MAX_VALUE);
}
@Override
- public void resumeConsumption() {
+ public void resumeConsumption(int availableCredit, boolean
hasUnfulfilledBacklog) throws Exception {
Review comment:
nit: availableCredit -> availableCredits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
