wuchong commented on a change in pull request #12130:
URL: https://github.com/apache/flink/pull/12130#discussion_r425116004
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/GenericMapData.java
##########
@@ -85,12 +85,15 @@ public boolean equals(Object o) {
return false;
}
GenericMapData that = (GenericMapData) o;
- return Objects.equals(map, that.map);
+ return Arrays.deepEquals(map.keySet().toArray(),
that.map.keySet().toArray()) &&
+ Arrays.deepEquals(map.values().toArray(),
that.map.values().toArray());
Review comment:
True. Maybe we need to foreach entries and get values using the entry
key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
