dawidwys commented on a change in pull request #12147:
URL: https://github.com/apache/flink/pull/12147#discussion_r425197840
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java
##########
@@ -910,40 +930,25 @@ public ExecutionConfig getExecutionConfig() {
final int inputParallelism =
getTransformation().getParallelism();
final AssignerWithPeriodicWatermarks<T> cleanedAssigner =
clean(timestampAndWatermarkAssigner);
- TimestampsAndPeriodicWatermarksOperator<T> operator =
- new
TimestampsAndPeriodicWatermarksOperator<>(cleanedAssigner);
+ final WatermarkStrategy<T> wms = new
AssignerWithPeriodicWatermarksAdapter.Strategy<>(cleanedAssigner);
+ final TimestampsAndWatermarksOperator<T> operator = new
TimestampsAndWatermarksOperator<>(wms);
Review comment:
how about we redirect to the non deprecated method? The only downside is
that the closure cleaner will be applied on the
AssignerWithPeriodicWatermarksAdapter.Strateg but I think its fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
