pnowojski commented on a change in pull request #11948:
URL: https://github.com/apache/flink/pull/11948#discussion_r425591726
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -469,7 +469,9 @@ public void onBuffer(Buffer buffer, int sequenceNumber, int
backlog) throws IOEx
if (notifyReceivedBarrier != null) {
receivedCheckpointId =
notifyReceivedBarrier.getId();
-
listener.notifyBarrierReceived(notifyReceivedBarrier, channelInfo);
+ if (notifyReceivedBarrier.isCheckpoint()) {
Review comment:
But the condition works the other way around? If we bump/increase
`receivedCheckpointId` here, it shouldn't matter. Spilling from input channels
starts only if `lastRequestedCheckpointId` is bumped over the
`receivedCheckpointId`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
