rkhachatryan commented on a change in pull request #12120:
URL: https://github.com/apache/flink/pull/12120#discussion_r425600935
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorImpl.java
##########
@@ -67,8 +70,11 @@ void run() {
} catch (Exception ex) {
thrown = ex;
} finally {
- cleanupRequests();
- dispatcher.fail(thrown == null ? new
CancellationException() : thrown);
+ try {
+ closeAll(this::cleanupRequests, () ->
dispatcher.fail(thrown == null ? new CancellationException() : thrown));
+ } catch (Exception e) {
+ LOG.error("unable to terminate properly", e);
+ }
Review comment:
I'll update the `thrown` field (`dispatcher.fail` is already called two
lines above).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
