tillrohrmann commented on a change in pull request #11854:
URL: https://github.com/apache/flink/pull/11854#discussion_r425631650
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/AbstractIterativeTask.java
##########
@@ -183,8 +186,9 @@ protected void closeLocalStrategiesAndCaches() {
@Override
public DistributedRuntimeUDFContext createRuntimeContext(MetricGroup
metrics) {
Environment env = getEnvironment();
+
return new IterativeRuntimeUdfContext(env.getTaskInfo(),
getUserCodeClassLoader(),
- getExecutionConfig(),
env.getDistributedCacheEntries(), this.accumulatorMap, metrics);
+ getExecutionConfig(),
env.getDistributedCacheEntries(), this.accumulatorMap, metrics,
ExternalResourceUtils.getExternalResourceInfo(env.getExternalResourceDrivers(),
env.getTaskManagerInfo().getConfiguration()));
Review comment:
But we don't know what the `ExternalResourceDriver` implementation does.
This can be arbitrary complex. I think we should be super careful with
introducing additional computational actions. Moreover, they should only take
effect if the user really needs them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
