becketqin commented on pull request #12122: URL: https://github.com/apache/flink/pull/12122#issuecomment-629142490
@StephanEwen Thanks for the review and suggestions. While I was addressing the comments, I realized that a class of `CoordinatedOperatorTransformation` may not be the best approach because this disallows the users to have coordinators in other transformations. So instead, I added a method of `getOperatorCoordinator()` method to the `PhysicalTransformation`. The method returns an `Optional` so the transformations can override it if necessary. I also adjusted `StreamingJobGraphGenerator#createChain()` a little bit so the logic looks slightly clearer. Just curious about the convention here. So is the convention only calling `instanceOf` in the `StreamGraphGenerator` and have typed parameter everywhere else? @TsReaper Thanks for the review. The latest update should have fixed the problem. Would you like to take another look? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
