manbuyun opened a new pull request #12169:
URL: https://github.com/apache/flink/pull/12169
## What is the purpose of the change
We need to add some custom labels on Prometheus, so we can query by them.
Now we can add jobName\groupingKey to PrometheusPushGatewayReporter in
version 1.10, but not in PrometheusReporter.
Can we add AbstractPrometheusReporter#addDimension method to support this,
so they will be no differences except for the metrics exposing mechanism
pulling/pushing.
## Brief change log
- AbstractPrometheusReporter unify parseLabels method
- AbstractPrometheusReporter add resolveDimensions method into
notifyOfAddedMetric
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
