curcur commented on pull request #11725: URL: https://github.com/apache/flink/pull/11725#issuecomment-629178179
> Test code already looks good (expecting the watermark tests to be implemented). > > Production code needs polishing: > > * API Javadoc should really help non-experts. > * Serializers should probably more use the existing abstractions like `KafkaDeserializationSchema` and not change/exhibit `TypeInformationSerializationSchema` This is difficult as what KafkaDeserializationSchema is providing T deserialize(ConsumerRecord<byte[], byte[]> record) throws Exception; and what I need, a TypeSerialer that can deserialize type by type. If I am asking for a KafkaDeserializationSchema, that's basically asking the user to write the deserializer themselves. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
