KurtYoung commented on a change in pull request #12076:
URL: https://github.com/apache/flink/pull/12076#discussion_r425774622
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java
##########
@@ -79,4 +81,31 @@
*/
String explainInternal(List<Operation> operations, ExplainDetail...
extraDetails);
+
+ /**
+ * Registers an external {@link TableSource} in this {@link
TableEnvironment}'s catalog.
+ * Registered tables can be referenced in SQL queries.
+ *
+ * <p>Temporary objects can shadow permanent ones. If a permanent
object in a given path exists, it will
+ * be inaccessible in the current session. To make the permanent object
available again one can drop the
+ * corresponding temporary object.
+ *
+ * @param name The name under which the {@link TableSource} is
registered.
+ * @param tableSource The {@link TableSource} to register.
+ */
+ void registerTableSource(String name, TableSource<?> tableSource);
Review comment:
Be consistent with other internal methods, add a `Internal` suffix
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
