rkhachatryan opened a new pull request #12173:
URL: https://github.com/apache/flink/pull/12173
## What is the purpose of the change
With Unaligned checkpoints enabled, when there are no channel state handles,
the underlying FS stream is still created. On discard it is not deleted because
it's not referenced by any state handles.
This prevents checkpoint from being subsumed.
This was causing e2e test `test_stateful_stream_job_upgrade.sh` to fail
(which is re-enabled in this PR).
## Brief change log
- add a check for emptyness of handles before creating an underlying stream
- add unit test
- revert reverse of [FLINK-17467][task][e2e] Modify existing upgrade test
to verify aligned savepoints
## Verifying this change
This change added tests and can be verified as follows:
- Added unit test: `ChannelStateCheckpointWriterTest.testEmptyState`
- Re-enabled e2e test: `test_stateful_stream_job_upgrade.sh`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
