KurtYoung commented on a change in pull request #12161:
URL: https://github.com/apache/flink/pull/12161#discussion_r425810399



##########
File path: 
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectTest.java
##########
@@ -222,6 +225,26 @@ private static void waitForJobFinish(TableResult 
tableResult) throws Exception {
                
tableResult.getJobClient().get().getJobExecutionResult(Thread.currentThread().getContextClassLoader()).get();
        }
 
+       @Test
+       public void testFunction() {
+               tableEnv.executeSql(String.format("create function my_abs as 
'%s'", GenericUDFAbs.class.getName()));

Review comment:
       do we have any test that can verify this created function can really 
work?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to