StephanEwen commented on a change in pull request #12137:
URL: https://github.com/apache/flink/pull/12137#discussion_r425829755
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/FailureHandlingResult.java
##########
@@ -122,7 +135,20 @@ public boolean canRestart() {
* @return result of a set of tasks to restart to recover from the
failure
*/
public static FailureHandlingResult restartable(Set<ExecutionVertexID>
verticesToRestart, long restartDelayMS) {
Review comment:
Happy to do that, it is simpler indeed. Originally, I wanted to preserve
the "spirit of the class", with its descriptive factory methods. But I think
you are right, the simplicity argument here is stronger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
