pnowojski commented on a change in pull request #12101:
URL: https://github.com/apache/flink/pull/12101#discussion_r426130049
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/TaskCheckpointingBehaviourTest.java
##########
@@ -141,13 +141,18 @@ public void testBlockingNonInterruptibleCheckpoint()
throws Exception {
assertNull(task.getFailureCause());
}
- private void runTestDeclineOnCheckpointError(AbstractStateBackend
backend) throws Exception{
-
+ private void runTestDeclineOnCheckpointError(AbstractStateBackend
backend, boolean expectFailure) throws Exception {
Review comment:
I don't like the reliance on passing consumers everywhere, it makes code
a spaghetti, when you have to traverse sometimes long call stacks to actually
find out what your method is actually doing.
But indeed, inlining is better option to passing the parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
