[
https://issues.apache.org/jira/browse/FLINK-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107352#comment-15107352
]
ASF GitHub Bot commented on FLINK-1045:
---------------------------------------
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1522
[FLINK-1045] Remove Combinable annotation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink rmCombinable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1522.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1522
----
commit 002e591c8fc7eef40d1e6ba4f075399b9b4e6577
Author: Fabian Hueske <[email protected]>
Date: 2016-01-18T14:57:49Z
[FLINK-1045] Remove Combinable annotation.
----
> Remove Combinable Annotation
> ----------------------------
>
> Key: FLINK-1045
> URL: https://issues.apache.org/jira/browse/FLINK-1045
> Project: Flink
> Issue Type: Improvement
> Components: DataSet API
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
> Priority: Blocker
> Labels: api-change, breaking-api
> Fix For: 1.0.0
>
>
> Since the {{combine()}} method was extracted into an interface, we can check
> if a function is combinable by checking if the interface is implemented.
> Hence, the {{Combinable}} annotation could be removed, IMHO.
> However, this would change the API because {{RichGroupReduceFunction}} could
> no longer have a default implementation of {{combine()}} that can be enabled
> by attaching the annotation.
> Right now, the {{Combinable}} annotation is just not necessary as the
> implementation of the interface tells the system everything it needs to know.
> Removing the {{Combinable}} annotation would also make the handling of
> different combinable functions easier. For example a function that implements
> the interfaces {{GroupReduceFunction}} and {{FlatCombineFunction}} does not
> need to attach the annotation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
