lirui-apache commented on a change in pull request #12108: URL: https://github.com/apache/flink/pull/12108#discussion_r426153661
########## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/SqlPartitionUtils.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser; + +import org.apache.calcite.sql.SqlLiteral; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlNodeList; +import org.apache.calcite.util.NlsString; + +import java.util.LinkedHashMap; + +/** + * Utils methods for partition DDLs. + */ +public class SqlPartitionUtils { + + private SqlPartitionUtils() { + } + + /** Get static partition key value pair as strings. + * + * <p>For character literals we return the unquoted and unescaped values. + * For other types we use {@link SqlLiteral#toString()} to get + * the string format of the value literal. + * + * @return the mapping of column names to values of partition specifications, + * returns an empty map if there is no partition specifications. + */ + public static LinkedHashMap<String, String> getPartitionKVs(SqlNodeList partitionSpec) { Review comment: In our name convention, a partition spec is usually a `SqlNodeList`. And this is following the example of `RichSqlInsert`, whose `getStaticPartitionKVs` returns a map. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
