zentol commented on a change in pull request #12172:
URL: https://github.com/apache/flink/pull/12172#discussion_r426168609
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name
${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
+ pushd ${FLINK_DIR}/..
+ tar -czf "${TEST_DATA_DIR}/flink.tgz" flink-*
+ popd
+ pushd ${TEST_DATA_DIR}
+ python -m SimpleHTTPServer 9999 &
Review comment:
I'd prefer not having to download another 60mb for this menial task;
that alone would imo discard it as a viable option as a utility sript.
##########
File path: flink-end-to-end-tests/test-scripts/common_docker.sh
##########
@@ -33,8 +33,25 @@ function containers_health_check() {
done
}
-function build_image_with_jar() {
- local job_artifacts=$1
- local image_name=${2:-flink-job}
- ./build.sh --from-local-dist --job-artifacts ${job_artifacts} --image-name
${image_name}
+function build_image() {
+ local image_name=${1:-flink-job}
+
+ echo "Starting fileserver for Flink distribution"
+ pushd ${FLINK_DIR}/..
+ tar -czf "${TEST_DATA_DIR}/flink.tgz" flink-*
+ popd
+ pushd ${TEST_DATA_DIR}
+ python -m SimpleHTTPServer 9999 &
Review comment:
I'd prefer not having to download another 60mb for this menial task;
that alone would imo discard it as a viable option as a utility script.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
