Github user uce commented on the pull request:

    https://github.com/apache/flink/pull/1524#issuecomment-173212170
  
    Hey Klou! Nice addition. A couple of users have asked for this. I guess 
they will be happy. I made some minor comments inline. The changes look good, I 
haven't tested it yet manually, but I've noticed that there are no test cases. 
I think we should add a simple test that ensures the basic expected behaviour 
(use default scheme is file, use default scheme if specified, don't use default 
scheme if explicit in URI etc.) After adding the tests and trying it out 
manually, I think it will be good to merge. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to