JingsongLi commented on a change in pull request #12206:
URL: https://github.com/apache/flink/pull/12206#discussion_r426350492
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShim.java
##########
@@ -205,4 +208,10 @@ SimpleGenericUDAFParameterInfo
createUDAFParameterInfo(ObjectInspector[] params,
*/
void createTableWithConstraints(IMetaStoreClient client, Table table,
Configuration conf,
UniqueConstraint pk, List<Byte> pkTraits, List<String>
notNullCols, List<Byte> nnTraits);
+
+ /**
+ * Create orc {@link BulkWriter.Factory} for different hive versions.
+ */
+ BulkWriter.Factory<RowData> createOrcBulkWriterFactory(
Review comment:
I created a orc shim improvement:
https://issues.apache.org/jira/browse/FLINK-17785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
