godfreyhe commented on a change in pull request #12188:
URL: https://github.com/apache/flink/pull/12188#discussion_r426426306
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientTest.java
##########
@@ -90,9 +92,9 @@ public void testFailedUpdateSubmission() throws Exception {
@Test
public void testSqlCompletion() throws IOException {
- verifySqlCompletion("", 0, Arrays.asList("SELECT", "QUIT;",
"RESET;"), Collections.emptyList());
- verifySqlCompletion("SELEC", 5,
Collections.singletonList("SELECT"), Collections.singletonList("QUIT;"));
- verifySqlCompletion("SELE", 0,
Collections.singletonList("SELECT"), Collections.singletonList("QUIT;"));
+ verifySqlCompletion("", 0, Arrays.asList("SOURCE", "QUIT;",
"RESET;"), Collections.emptyList());
Review comment:
before this pr, all commands are hint candidates. after this refactor,
only the commands who has regex pattern are hint candidates, or fallback to
Table API hinting (will delegate to `tableEnv.getCompletionHints` in
LocalExecutor). in `MockExecutor`, `completeStatement` method only returns
`HintA` and `Hint B`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
