pnowojski opened a new pull request #12231:
URL: https://github.com/apache/flink/pull/12231
FLINK-16536 (re) introduced requestPartitions on critical path of
AbstractRecordReader, which
amounts to couple of viritual calls, one lock acquisition and one volatile
read. This overhead
is what's cuasing performance drop.
We can avoid subsequentional redundant calls, by checking against a local
variable if we have
already requested partitions or not.
Benchmark: networkThroughput: (channelsFlushTimeout = 100,100ms)
results after the fix:
~49000 ops/ms
before:
~11000 ops/ms
## Verifying this change
This change is covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs
/ not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
